[CELEBORN-1744] Cleanup old ResourceConsumption metrics #2946
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
commented
Nov 26, 2024
common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala
Outdated
Show resolved
Hide resolved
turboFei
commented
Nov 26, 2024
| @@ -677,8 +677,6 @@ private[celeborn] class Worker( | |||
| private def handleTopResourceConsumption(userResourceConsumptions: util.Map[ | |||
| UserIdentifier, | |||
| ResourceConsumption]): Unit = { | |||
| // Remove application top resource consumption gauges to refresh top resource consumption metrics. | |||
| removeAppResourceConsumption(topApplicationUserIdentifiers.keySet().asScala) | |||
There was a problem hiding this comment.
we can leave it be cleaned by the cleaner thread?
There was a problem hiding this comment.
I wonder the metrics with appId label lost is related with this.
|
gentle ping @SteNicholas @FMX |
turboFei
changed the title
turboFei
changed the title
|
Roger that. Will review it tonight.
… 2024年11月26日 15:07，Fei Wang ***@***.***> 写道：
gentle ping @SteNicholas <https://github.com/SteNicholas> @FMX <https://github.com/FMX>
—
Reply to this email directly, view it on GitHub <#2946 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7VNUPUIAGYNZB7KGDFAN32CQM37AVCNFSM6AAAAABSPCD3XSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJZHAZDEOBXHE>.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Start the cleaner to cleanup old metrics for
ResourceConsumptionSourceandThreadPoolSource.Why are the changes needed?
Issue 1:
I found that, an application was finished long time ago, but I can still view the metrics in grafana dashboards.
Likes:
Issue 2:
I am working on the Celeborn Alert SOP for how to figure out the top app usages.
For this expr, I can not find the applicationId that wroten 140TB shuffle data.
But with this expr, the shuffle size match.
Please note that, the celeborn cluster has not take traffic, and only one testing application was running at that time.
Per the metrics, it seems that some metrics
metrics_diskBytesWritten_Valuewith applicationId label were lost.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.