[CELEBORN-1726][FOLLOWUP] Avoid NPE when transition worker state #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
==========================================
+ Coverage 32.07% 32.55% +0.49%
==========================================
Files 331 333 +2
Lines 19749 19912 +163
Branches 1778 1796 +18
==========================================
+ Hits 6332 6481 +149
+ Misses 13071 13070 -1
- Partials 346 361 +15 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
RexXiong
approved these changes
Nov 22, 2024
turboFei
approved these changes
Nov 22, 2024
SteNicholas
pushed a commit
that referenced
this pull request
Nov 22, 2024
### What changes were proposed in this pull request? Avoid NPE when transition worker state ### Why are the changes needed? Fix test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need. Closes #2938 from reswqa/fix-npe. Authored-by: Weijie Guo <[email protected]> Signed-off-by: SteNicholas <[email protected]> (cherry picked from commit d722b76) Signed-off-by: SteNicholas <[email protected]>
|
Merged to main(v0.6.0) and branch-0.5(v0.5.2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid NPE when transition worker state
Why are the changes needed?
Fix test.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need.