Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new contribution agreement from Ghais Issa #1792

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

michaelsembwever
Copy link
Member

patch by Mick Semb Wever; reviewed by XXX for CASSANDRA-19723

Copy link
Contributor

@martin-sucha martin-sucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related comment: #1751 (comment)

… Das

 patch by Mick Semb Wever; reviewed by Martin Sucha for CASSANDRA-19723
@michaelsembwever
Copy link
Member Author

Related comment: #1751 (comment)

Oh, thanks for point that out, now I see/remember there's others too that have since given their approval.
Commit updated…

@martin-sucha
Copy link
Contributor

It is not clear to me whether Árni Dagur and Tushar Das should have an asterisk, since the comments #1751 (comment) and #1751 (comment) both say that they haven't signed the CLA and the top of the NOTICE file says

Where The Gocql Authors for copyright purposes are below. Those marked with
asterisk have agreed to donate (copyright assign) their contributions to the
Apache Software Foundation, signing CLAs when appropriate.

I haven't looked into whether signing the CLA is necessary in this case or not.

@michaelsembwever
Copy link
Member Author

It is not clear to me whether Árni Dagur and Tushar Das should have an asterisk, since the comments #1751 (comment) and #1751 (comment) both say that they haven't signed the CLA and the top of the NOTICE file says

They both expressed (at least I understood) that their work could be used and that signing the CLA didn't seem necessary. That's enough for us, as we're still keeping the copyright in place for work pre-donation.

Copy link
Contributor

@martin-sucha martin-sucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That solves my concerns.

@michaelsembwever michaelsembwever merged commit 55a2591 into apache:trunk Aug 7, 2024
16 checks passed
@michaelsembwever michaelsembwever deleted the mck/CASSANDRA-19723-1 branch August 7, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants