Filter camel properties to camelMain #1640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdar
requested changes
May 28, 2024
There was a problem hiding this comment.
@seanshi007 First of all thanks a lot for the contribution!
Please see my inline comments.
| @@ -227,7 +229,10 @@ public CamelKafkaConnectMain build(CamelContext camelContext) { | |||
| camelMain.configure().setDumpRoutes(Boolean.TRUE.toString()); | |||
|
|
|||
| Properties camelProperties = new Properties(); | |||
| camelProperties.putAll(props); | |||
| Map<String, String> camelProps = props.entrySet().stream() | |||
There was a problem hiding this comment.
The problem here is that, theoretically (since it is not explicitly tested in tests, would be possible to add properties not starting with camel. as a way to configure some other useful stuff like factories for some camel components i.e. as in https://github.com/apache/camel-kafka-connector/blob/main/connectors/camel-kafka-connector-fix-dependencies.properties#L25 what about having a specific property say camel.kafkaconnector.filtered.props as a comma separated list of sensitive properties that one may want to explicitly filter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all properties are first put into camelProperties and then logged (after filter out sensitive keys defined in Camel core). When producer or consumer is overridden, e.g. when "producer.override.sasl.jaas.config" is set, which will not be filtered out and hence being logged and causing potential secret exposure.
This change will filter out non-camel properties as they will not be used by camel core anyway.