Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove amazon-web-services and kinesis folders + settings.gradle cleanup #33456

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Dec 27, 2024

Fully remove deprecated v1 aws IOs. #33416 and #33455 removed all dependencies of this, so this only deletes things. Specifically:

  • Deletes sdks/java/io/amazon-web-services
  • Deletes sdks/java/io/kinesis
  • Removes v1 tasks from settings.gradle.kts
  • Uses v2 instead of v1 for filesystem in buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy (basically a no-op)

Part of #33430


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm marked this pull request as ready for review December 30, 2024 17:44
@damccorm
Copy link
Contributor Author

cc/ @aromanenko-dev @Abacn

@damccorm damccorm changed the title [WIP] Remove amazon-web-services and kinesis folders + settings.gradle cleanup Remove amazon-web-services and kinesis folders + settings.gradle cleanup Dec 30, 2024
@damccorm
Copy link
Contributor Author

Actually, moving back to draft. I missed one more piece which needs to be dealt with first -

testRuntimeOnly it.project(path: ":sdks:java:io:amazon-web-services", configuration: "testRuntimeMigration")

@damccorm damccorm marked this pull request as draft December 30, 2024 17:50
@damccorm damccorm changed the title Remove amazon-web-services and kinesis folders + settings.gradle cleanup [WIP] Remove amazon-web-services and kinesis folders + settings.gradle cleanup Dec 30, 2024
@damccorm
Copy link
Contributor Author

damccorm commented Dec 30, 2024

Ok - should be fine/ready for review now. It was a simple fix after all since updating the filesystem for tests has no real implications here.

@damccorm damccorm marked this pull request as ready for review December 30, 2024 18:14
@damccorm damccorm changed the title [WIP] Remove amazon-web-services and kinesis folders + settings.gradle cleanup Remove amazon-web-services and kinesis folders + settings.gradle cleanup Dec 30, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

1 similar comment
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@damccorm damccorm merged commit 7800360 into master Dec 30, 2024
23 checks passed
@damccorm damccorm deleted the users/damccorm/aws-v1-removal-final branch December 30, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants