-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove amazon-web-services and kinesis folders + settings.gradle cleanup #33456
Conversation
…mccorm/aws-v1-removal-final
Actually, moving back to draft. I missed one more piece which needs to be dealt with first -
|
Ok - should be fine/ready for review now. It was a simple fix after all since updating the filesystem for tests has no real implications here. |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
1 similar comment
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Fully remove deprecated v1 aws IOs. #33416 and #33455 removed all dependencies of this, so this only deletes things. Specifically:
Part of #33430
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.