-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "stage_file_with_retry" for robust file staging #33436
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33436 +/- ##
============================================
- Coverage 57.44% 57.14% -0.30%
Complexity 1475 1475
============================================
Files 979 979
Lines 155237 155218 -19
Branches 1076 1076
============================================
- Hits 89181 88705 -476
- Misses 63840 64297 +457
Partials 2216 2216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @jrmccluskey |
Job creation involves staging multiple files (artifacts, pipeline proto, job file, template). While artifact staging has retry logic, these other types do not, leading to potential job failures due to transient service issues.
This commit introduces
stage_file_with_retry
, a new function with built-in retry logic. Severalstage_file
calls inapiclient.py
have been replaced with this new function.Internal bug id: 384579652.