Use other fallback coders for protobuf message base class #33432
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunping
changed the title
|
r: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Looks like there's still some test failures. Is |
shunping
changed the title
The failed check is related to "google.protobuf.message" not being imported. It seems that the global flag "TYPE_CHECKING" is set differently on gha vs in my local machine. It is fixed now. PTAL. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses internal test failures (internal bug ID: 385108730) introduced by recent Reshuffle code changes. It does not impact existing Reshuffle functionality, but is a necessary prerequisite for upcoming Reshuffle modifications.