-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate lineage counters to bounded tries. #33381
Conversation
Depends on #33378. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
e9ed97a
to
b76f5ca
Compare
b76f5ca
to
30288ae
Compare
Rebased on master now that upstream is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Has this change tested on Dataflow runner to see how the service behaves once 2.62.0 start sending BoundedTrie as a metric which it does not know about? If not then, I can help with that if needed. Since on submission of this PR 2.62.0 jobs will start sending it.
One thing I am thinking is if we need stringSetDisabled
kind of flag for BoundedTrie in python or not. We do not have stringSetDisabled
for python as of now. I think it will be ok to go without it because
- The race issue we saw for large GCS IO filepaths was java specific, given Python does a traditional blocking lock this should not happen here.
- Python SDK usage is lower compared to Java but we have also not verified the very large GCSIO behavior at scale. This I can do this month.
The UW gracefully ignores metric types it does not recognize. (This is why the string set changes could go in the SDK before they went into the service as well.) In addition, IIRC the PreCommit Python Integration (and others) run a couple of tests against dataflow. (I'll ensure all the tests pass before merging.) I also don't think we need a |
SG. Oh yes UW part I remember now. IIRC we had to disable reporting StringSet for legacy worker though as tests started failing. I believe router will reject these with fail-close |
Yes. Python doesn't have to worry about the legacy worker anymore. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33381 +/- ##
============================================
+ Coverage 57.37% 57.44% +0.07%
Complexity 1475 1475
============================================
Files 973 979 +6
Lines 154905 155237 +332
Branches 1076 1076
============================================
+ Hits 88879 89181 +302
- Misses 63810 63840 +30
Partials 2216 2216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4a91890
to
14f7caf
Compare
Also cleans up the filesystem-specific logic.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.