Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandatory beam-sdks-io-kafka dependency for dataflow worker jar #33302

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Dec 6, 2024

The introduced dependency breaks internal import and effectively re-introduced #21096

. see #32402 (comment)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. Goes from a bad design to a hack :-)

Since it is v1 worker not work coming up with a good design. Will portability have similar needs?

@Abacn
Copy link
Contributor Author

Abacn commented Dec 6, 2024

portable SDK harness also configured JVMInitializer on startup:

JvmInitializers.runBeforeProcessing(options);

so this change added the support of this feature flag in portability. However portable side the metrics is not ready yet afaik.

@Abacn Abacn merged commit 04b059f into apache:master Dec 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants