Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Iceberg to v1.6.1 #33294

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Dec 5, 2024

We can't bump to v1.7.0 as java 8 support was dropped.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@regadas
Copy link
Contributor Author

regadas commented Dec 5, 2024

assign set of reviewers

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @johnjcasey

Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@ahmedabu98
Copy link
Contributor

Hey @regadas, thanks for making this change!

Can you please resolve the conflicts and trigger the Iceberg integration tests by modifying this file

@regadas regadas force-pushed the chore_bump_iceberg_1.6.1 branch from abdcb0c to ef837b1 Compare December 17, 2024 21:58
@github-actions github-actions bot added build and removed build labels Dec 17, 2024
@regadas regadas force-pushed the chore_bump_iceberg_1.6.1 branch from ef837b1 to 384d549 Compare December 17, 2024 22:03
@github-actions github-actions bot added build and removed build labels Dec 17, 2024
@regadas
Copy link
Contributor Author

regadas commented Dec 18, 2024

Hi @ahmedabu98 thanks for taking a look! let me know if smth else is missing

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Out of curiosity, what motivated this version upgrade?

@ahmedabu98 ahmedabu98 modified the milestone: 2.62.0 Release Dec 18, 2024
@regadas
Copy link
Contributor Author

regadas commented Dec 19, 2024

@ahmedabu98 I was not hitting any particular issue in specific. Trying to keep things updated since between 1.4.3 and 1.6.1, parquet support, table scan's have been improved and there's some spec additions.

@ahmedabu98
Copy link
Contributor

Sounds good 👍🏽 merging now.

Thanks for tagging me on your other PRs, I'll take a look at them later today. Can you resolve their conflicts and similarly trigger the integration tests too?

@ahmedabu98 ahmedabu98 merged commit ca8a35a into apache:master Dec 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants