Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "SolaceIO.Read: handle occasional cases when finalizeCheckpoint is not executed (#32962)" (#33259) #33269

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

bzablocki
Copy link
Contributor

Reapply changes that were introduced and reverted in #32962. See the main discussion there.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@bzablocki
Copy link
Contributor Author

@ppawel FYI, reapplying changes here.
@Abacn sorry for the mixup, these are exactly the same changes as in #32962. Turns out the reason behind failing integration tests were my other changes from a different PR. Would you mind merging these changes? The review was in #32962.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@bzablocki
Copy link
Contributor Author

Run Java_Solace_IO_Direct PreCommit

@ppawel
Copy link

ppawel commented Dec 4, 2024

OK, thanks for the info @bzablocki , I am currently preparing a version for us with 2.61.0 and this PR applied. Is it planned on your side to do an official backport (2.61.1 or something like that)?

@bzablocki
Copy link
Contributor Author

I'm afraid a patch to an already released version can only be applied in some very specific cases, specifically when there is a major performance issue in the new version, or some serious bug is introduced. I don't think this PR qualifies for that.

@bzablocki
Copy link
Contributor Author

R: @Abacn
Would you mind merging these changes? This PR is exactly the same as #32962, which was reverted.
The reason behind failing integration tests were my other changes from a different PR. The review was in #32962.

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit e2ff659 into apache:master Dec 11, 2024
19 checks passed
@Abacn
Copy link
Contributor

Abacn commented Dec 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants