-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin Dataflow legacy worker container for Nexmark test #33224
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Instead of doing this, should we be fixing #30606 (comment) so that it points to a java 11 container? |
This PR is to fix that comment. The effect of '--workerHarnessContainerImage=' is to direct the container to an internally built (Java 8) container, which made it incompatible with pipeline submission environment. Remove it, it will use beam-master container with the same Java version of the host, while still overrides dataflowWorkerJar |
My question was: should we make |
I see, yeah, we should move the internal one to java11, will raise internal tracker for that |
Opened an internal issue (tracking: 381121973) and initial changes. It seems the scope of change for migrating the staging container to Java11 is nontrivial, and needs rollouts from Dataflow service side (which is currently blocked). Could we proceed with this change for this workflow at the moment? |
Yeah, that is fine - thanks |
fix
#30606Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.