Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the new flink container precommit #33217

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

liferoad
Copy link
Collaborator

Addresses #33180


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Nov 25, 2024
@liferoad liferoad marked this pull request as ready for review November 25, 2024 20:30
@liferoad liferoad requested a review from damccorm November 25, 2024 20:40
@liferoad
Copy link
Collaborator Author

Looks like I cannot trigger the new workflow file after I changed the workers to 2.

@damccorm
Copy link
Contributor

Looks like I cannot trigger the new workflow file after I changed the workers to 2.

Yeah, this is a limitation of github's pull_request_target trigger. See https://github.com/apache/beam/tree/master/.github/workflows#testing-workflow-updates on how to workaround

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@damccorm damccorm merged commit ea93ce5 into apache:master Nov 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants