Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yaml] remove PubSubLite from API docs #33184

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Nov 21, 2024

PubSubLite is deprecated as per https://cloud.google.com/pubsub/lite/docs, scheduled to be turned down March 18, 2026, and is no longer available for new customers as of September 24, 2024.

In order to avoid confusion for new Beam YAML users, this transform will be hidden from the API docs, but still usable within the YAML API


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Polber
Copy link
Contributor Author

Polber commented Nov 21, 2024

R: @robertwb

@Polber
Copy link
Contributor Author

Polber commented Nov 21, 2024

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.93%. Comparing base (a06454a) to head (f5102b4).

Files with missing lines Patch % Lines
sdks/python/apache_beam/yaml/generate_yaml_docs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33184      +/-   ##
============================================
- Coverage     58.93%   58.93%   -0.01%     
  Complexity     3112     3112              
============================================
  Files          1133     1133              
  Lines        174989   174989              
  Branches       3343     3343              
============================================
- Hits         103133   103130       -3     
- Misses        68511    68514       +3     
  Partials       3345     3345              
Flag Coverage Δ
python 81.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Jeffrey Kinard <[email protected]>
@Polber
Copy link
Contributor Author

Polber commented Dec 4, 2024

Test failures seem unrelated

@damccorm damccorm merged commit a9a82a1 into apache:master Dec 4, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants