-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy.int64 type is not serialized correctly in Python 3.11 and Python 3.12 #33137
Changes from all commits
2edbc32
890e41c
d809b3b
baea2a2
7e7247d
fdda117
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -510,6 +510,9 @@ def encode_special_deterministic(self, value, stream): | |
stream.write_byte(NESTED_STATE_TYPE) | ||
self.encode_type(type(value), stream) | ||
state_value = value.__getstate__() | ||
if value is not None and state_value is None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are we checking that value is not There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This just indicates |
||
# https://github.com/apache/beam/issues/33020 | ||
raise TypeError(self._deterministic_encoding_error_msg(value)) | ||
try: | ||
self.encode_to_stream(state_value, stream, True) | ||
except Exception as e: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned that just checking that this value is not None is insufficient, as objects with custom pickling protocols can still use this method and the root
object
now defines a default for anything with dict or slots.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it is insufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#33157