Switch to use ConcurrentMap for StringSetData

[Abacn]

Fix #33054

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[Abacn]

tested that the test before this change reliably fails with

java.util.ConcurrentModificationException
	at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1511)
	at java.base/java.util.HashMap$KeyIterator.next(HashMap.java:1534)
	at java.base/java.util.AbstractCollection.toArray(AbstractCollection.java:144)
	at java.base/java.util.ArrayList.<init>(ArrayList.java:179)
	at org.apache.beam.runners.core.metrics.StringSetCellTest.testStringSetCellConcurrentAddRetrivial(StringSetCellTest.java:124)

[Abacn]

tested on a pipeline continuously writing Lineage

before (Dataflow job id: 2024-11-08_11_36_49-8094892231622614854):

after (Dataflow job id: 2024-11-08_11_44_52-6414777021729411991):

no "Unexpected exception while trying to send counter updates" error log

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck added as fallback since no labels match configuration

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[jonathan-lemos]

Rest of this LGTM.

[jonathan-lemos]

1s sleep in a 3s test doesn't give much room to find races.

Does this test fail without your changes?

[Abacn]

Here it is 1 ms sleep. it does - #33057 (comment).

[jonathan-lemos]

My mistake. I was thinking Python where it's in seconds and not ms.

[jonathan-lemos]

We should assert that the contents of the snapshot are not corrupt.

Maybe we keep track of the highest integer reached by the thread, and assert that at the end, the snapshot contains all of [0, N].

[Abacn]

Sounds good, added assert.

[Abacn]

GCP IO PreCommit failing SpannerChangeStream test testInvalidRecordReceived not related