Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka SDF add Poll Latency Metrics #32933

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Oct 24, 2024

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from 6846335 to 59f5752 Compare October 28, 2024 17:53
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from 59f5752 to 1855c5e Compare October 28, 2024 17:57
@github-actions github-actions bot removed the direct label Oct 28, 2024
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch 2 times, most recently from 7401920 to 57b1e9e Compare October 28, 2024 19:14
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch 5 times, most recently from 08e31c4 to 3c950cf Compare October 28, 2024 23:57
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from 3c950cf to a82e6d7 Compare October 28, 2024 23:58
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch 4 times, most recently from a76ddc6 to e2847b8 Compare October 29, 2024 01:16
@github-actions github-actions bot added the gcp label Oct 29, 2024
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch 2 times, most recently from 8dc0b82 to 21bb7f7 Compare October 29, 2024 06:00
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from 21bb7f7 to ebd3e86 Compare October 29, 2024 23:45
@github-actions github-actions bot added the jet label Oct 29, 2024
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch 4 times, most recently from caf87d3 to 92d5451 Compare October 30, 2024 04:16
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from 92d5451 to e37b852 Compare October 30, 2024 04:40
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from e37b852 to a8cc5e3 Compare October 30, 2024 18:48
@Naireen
Copy link
Contributor Author

Naireen commented Oct 30, 2024

Run Java_GCP_IO_Direct PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Oct 30, 2024

Run Python_Coverage PreCommit

@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from a8cc5e3 to 6f95d47 Compare October 30, 2024 21:19
@Naireen
Copy link
Contributor Author

Naireen commented Oct 30, 2024

Run Java PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Oct 30, 2024

Run Java_GCP_IO_Direct PreCommit

@Naireen Naireen changed the title Kafka uw poll metrics Kafka SDF add Poll Latency Metrics Oct 31, 2024
@Naireen
Copy link
Contributor Author

Naireen commented Oct 31, 2024

Run GoPortable PreCommit

@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch 2 times, most recently from f92c801 to 4cb98fb Compare October 31, 2024 22:55
@Naireen
Copy link
Contributor Author

Naireen commented Oct 31, 2024

Run Prism_Python PreCommit 3.9

@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from 4cb98fb to c46ed3b Compare November 1, 2024 17:41
@Naireen
Copy link
Contributor Author

Naireen commented Nov 5, 2024

Run Python_Coverage PreCommit

@Naireen
Copy link
Contributor Author

Naireen commented Nov 5, 2024

Run Java PreCommit

@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from c46ed3b to 281c0f5 Compare November 11, 2024 17:22
Naireen added 2 commits November 12, 2024 00:53
Address Sam's comments

add UW support
@Naireen Naireen force-pushed the kafka_uw_poll_metrics branch from 281c0f5 to 27aca32 Compare November 12, 2024 00:57
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.90%. Comparing base (2488ca1) to head (27aca32).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #32933   +/-   ##
=========================================
  Coverage     58.90%   58.90%           
- Complexity     3112     3113    +1     
=========================================
  Files          1131     1131           
  Lines        174613   174613           
  Branches       3357     3359    +2     
=========================================
+ Hits         102856   102857    +1     
  Misses        68403    68403           
+ Partials       3354     3353    -1     
Flag Coverage Δ
java 69.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant