-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typecheck err msg #32880
Update typecheck err msg #32880
Changes from 11 commits
38ef421
9973270
afd0014
d762186
934bd8c
f331aa3
5f2529b
9ae70ce
3ec5bda
797b8eb
0cee1f3
e46b224
28ab5c8
6ad169f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ requires = [ | |
# Avoid https://github.com/pypa/virtualenv/issues/2006 | ||
"distlib==0.3.7", | ||
# Numpy headers | ||
"numpy>=1.14.3,<2.2.0", # Update setup.py as well. | ||
"numpy>=1.14.3,<1.27", # Update setup.py as well. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please revert this change (I'm assuming this was unintentional) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Huh, yeah I didn't change this intentionally. Maybe weird git operation artifact. Reverting |
||
# having cython here will create wheels that are platform dependent. | ||
"cython>=3.0,<4", | ||
## deps for generating external transform wrappers: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this type check is done up here rather than modifying the check nested in the for loop? It looks kind of redundant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is specifically a check for the main element while the loop is checking presumably side inputs.