[Do not Merge] [WIP] Combine.perKeyWithBucketing: Combiner for reducing key cardinality #32831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine.perKeyWithBucketing(childCombiner, numBuckets): applies the child combiner to the PCollection using numberOfBuckets number of intermediate keys. Example usage ``` input.apply(Combine.perKeyWithBucketing(yourCombineFn, desiredNumKeys)) ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32831 +/- ##
============================================
+ Coverage 57.41% 58.93% +1.52%
- Complexity 1475 3102 +1627
============================================
Files 968 1131 +163
Lines 154224 174643 +20419
Branches 1076 3330 +2254
============================================
+ Hits 88546 102931 +14385
- Misses 63477 68373 +4896
- Partials 2201 3339 +1138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing this in favor of #33318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine.perKeyWithBucketing(childCombiner, numBuckets)applies the childcombiner to the PCollection using numberOfBuckets number of intermediate keys.
This is a POC, sending it now to share and get early feedback.
TODO: Add tests, pick better names.
Example usage