Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TransformingMap serializable #32810

Merged
merged 2 commits into from
Oct 16, 2024
Merged

make TransformingMap serializable #32810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b36877
make TransformingMap serializable
reuvenlax Oct 16, 2024
288e30f
trigger iceberg
reuvenlax Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/IO_Iceberg_Integration_Tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 3
"modification": 4
}
3 changes: 2 additions & 1 deletion sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ByteBuddyUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import static org.apache.beam.sdk.util.ByteBuddyUtils.getClassLoadingStrategy;
import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkNotNull;

import java.io.Serializable;
import java.lang.reflect.Constructor;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
Expand Down Expand Up @@ -511,7 +512,7 @@ public static <K1, V1, K2, V2> TransformingMap<K1, V1, K2, V2> getTransformingMa
return new TransformingMap<>(sourceMap, keyFunction, valueFunction);
}

public static class TransformingMap<K1, V1, K2, V2> implements Map<K2, V2> {
public static class TransformingMap<K1, V1, K2, V2> implements Map<K2, V2>, Serializable {
private final Map<K2, V2> delegateMap;

public TransformingMap(
Expand Down
Loading