-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Read with Meatadata in MqttIO
#32668
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks great! Left a couple of suggestions but will leave it up to you
sdks/java/io/mqtt/src/main/java/org/apache/beam/sdk/io/mqtt/MqttIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/mqtt/src/main/java/org/apache/beam/sdk/io/mqtt/MqttRecord.java
Outdated
Show resolved
Hide resolved
@ahmedabu98 |
- remove MqttRecordCoder - refactor MqttRecord to use AutoValueSchema - change related test
Looks great! merging now |
The added test is flaky: https://github.com/apache/beam/runs/31378942008 Testing MqttIO has been challenging, for example sleep were added in some test to mitigate the timing issue: #32500 . Or consider using countdown, etc to handle async |
@Abacn |
* add support for read with metadata in MqttIO * Update CHANGES.md * update javadoc * update javadoc * refactor : change to use SchemaCoder in MqttIO - remove MqttRecordCoder - refactor MqttRecord to use AutoValueSchema - change related test
Please add a meaningful description for your change here
fixes #32195
This PR contains these changes
MqttIO
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.