Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick iceberg autosharding #32655

Closed
wants to merge 9 commits into from

Conversation

ahmedabu98
Copy link
Contributor

Cherrypicking #32612

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor

Abacn commented Oct 4, 2024

this cherry pick has different diff than the original PR, could you please simply run git cherry-pick d84cfffd017342542cc1dc3e7ae30452a485e3b1 on release-2.60.0 branch and push to the PR?

@ahmedabu98
Copy link
Contributor Author

ahmedabu98 commented Oct 4, 2024

I think the only missing change is to .github/trigger_files/IO_Iceberg_Integration_Tests.json:
image

but an identical change has already been committed (probably from #32621): https://github.com/apache/beam/blob/release-2.60.0/.github/trigger_files/IO_Iceberg_Integration_Tests.json

@Abacn
Copy link
Contributor

Abacn commented Oct 4, 2024

sorry if not clear, git cherry-pick ... will give a single commit to this PR, currently there are 9 commits. But on the master branch history the original PR merged into a single commit (d84cfff)

@ahmedabu98
Copy link
Contributor Author

I see. Let's move to #32663 then

@ahmedabu98 ahmedabu98 closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants