Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in _get_function_body_without_inners for module sdks.python.transforms.core #32590

Closed
wants to merge 11 commits into from
Closed

Fix a bug in _get_function_body_without_inners for module sdks.python.transforms.core #32590

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f1d9e93
Log Warning if process function return None
DKER2 Sep 24, 2024
3cdb629
Fix get function without inner
DKER2 Sep 25, 2024
9170808
check the first def_line also
DKER2 Sep 25, 2024
9370ed2
rename variable
DKER2 Sep 25, 2024
6219664
add strip function
DKER2 Sep 25, 2024
5a3c1a6
reformat function
DKER2 Sep 25, 2024
3bfc43d
refactor code
DKER2 Sep 25, 2024
278d186
fix bug in get function body
DKER2 Sep 29, 2024
f07d2cd
Merge branch 'master' into master
DKER2 Sep 29, 2024
e819366
retrigger test
DKER2 Sep 29, 2024
25d5431
retrigger test
DKER2 Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/transforms/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,8 +1504,8 @@ def _check_fn_use_yield_and_return(fn):
has_yield = False
has_return = False
return_none_warning = (
"No iterator is returned by the process method in %s.",
fn.__self__.__class__)
f"No iterator is returned by the "
f"process method in {fn.__self__.__class__}.")
for line in source_code.split("\n"):
lstripped_line = line.lstrip()
if lstripped_line.startswith("yield ") or lstripped_line.startswith(
Expand Down
Loading