Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade grpc #32449

Merged
merged 1 commit into from
Sep 13, 2024
Merged

downgrade grpc #32449

merged 1 commit into from
Sep 13, 2024

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Sep 12, 2024

Fixes: #32324

Tested: apache/beam/actions/runs/10839063060/job/30078643883?pr=32446

One more run in flight: https://github.com/apache/beam/actions/runs/10840227044

GRPCIO issue: grpc/grpc#37710


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@tvalentyn
Copy link
Contributor Author

R: @lostluck
cc: @shunping

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@lostluck
Copy link
Contributor

Tomorrow I'll look into ensuring the GoPortable tests run when these. Python deps change, to reduce a regression chance. Basically just needs to be the deps file here, and anything else in the portable python runner code.

@tvalentyn
Copy link
Contributor Author

the dependency had an upper bound, so that we find sooner than later that an upgrade breaks us

@tvalentyn tvalentyn merged commit bcf4042 into apache:master Sep 13, 2024
224 of 225 checks passed
@tvalentyn tvalentyn deleted the downgrade_grpc branch September 13, 2024 00:49
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The PreCommit GoPortable job is flaky
3 participants