Remove Python 3.8 GitHub Actions Runs #32429
Conversation
Port python 3.8 actions changes to new branch
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
LGTM. You can trigger precommit suites to run off your py38dep fork. For example, I triggered these runs: beam_PreCommit_PythonLint: https://github.com/apache/beam/actions/runs/10815932208 I think the test result will accurately represent what will happen after this PR is merged. |
| @@ -20,10 +20,10 @@ class PythonTestProperties { | |||
| // Indicates all supported Python versions. | |||
| // This must be sorted in ascending order. | |||
| final static List<String> ALL_SUPPORTED_VERSIONS = [ | |||
| '3.8', | |||
| '3.9', | |||
There was a problem hiding this comment.
is this file still being used given that we don't use Jenkins?
There was a problem hiding this comment.
I started to update the jenkins files and stopped once I realized what they were, it's worth doing some cleanup here eventually
| @@ -271,7 +271,7 @@ commands = | |||
| bash {toxinidir}/scripts/pytest_validates_runner.sh {envname} {toxinidir}/apache_beam/runners/portability/spark_runner_test.py {posargs} | |||
|
|
|||
|
|
|||
| [testenv:py{38,39}-pyarrow-{3,9,10,11,12,13,14,15,16}] | |||
| [testenv:py{39,310}-pyarrow-{3,9,10,11,12,13,14,15,16}] | |||
There was a problem hiding this comment.
keeping just 39 is also fine here, since 310 is not used anywhere
I did kick off some of those manually but didn't grab the run logs, we were green on the precommits I ran. |
|
Linting failed, unhappy with something in yaml IO. I'm re-running to confirm and then I'll fix if needed. I think the game plan here would be to merge on Monday so there aren't any breakages over the weekend? |
|
SGTM |
|
Okay the linting failure is a yaml warning that I had already disabled previously, the syntax for disabling that check may be different but it's an easy fix once we're merged. Just need an approval to move forward now. |
|
this may have caused beam_LoadTests_Python_Combine_Flink_Batch failing. For some reason, I still see |
* [WIP] Remove Python 3.8 targets from Actions * revert changes to 3.9 build.gradle * More gradle cleanup * Add posargs * Update local-env-setup.sh * Fix default env python version * More places to update python version refs * mypy/linting fixes * yapf * Update other locations * update more files * update standard_external_transforms.yaml * update test case that fails on 3.8 -> 3.9
Migrates 3.8 actions to 3.9. New workflows were run in #32329, widespread failures are expected on this PR as actions are being run on 3.8 but that python version is not being installed. Does not remove 3.8 support from Beam, that will be in a followup PR.
Part of #31192
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.