Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont run flaky test on windows #32419

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Dont run flaky test on windows #32419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a255d78
Revert "Try deflaking test timing (#32351)"
damccorm Sep 10, 2024
15fe088
Dont run flaky test on windows
damccorm Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions sdks/python/apache_beam/ml/inference/base_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,21 +878,22 @@ def test_run_inference_timeout_not_hit(self):
bad_without_error, equal_to(expected_bad), label='assert:failures')

@unittest.skipIf(
sys.version_info < (3, 11),
sys.platform == "win32" or sys.version_info < (3, 11),
"This test relies on the __del__ lifecycle method, but __del__ does " +
"not get invoked in the same way on older versions of Python, " +
"breaking this test. See " +
"not get invoked in the same way on older versions of Python or on " +
"windows, breaking this test. See " +
"github.com/python/cpython/issues/87950#issuecomment-1807570983 " +
"for example.")
def test_run_inference_timeout_does_garbage_collection(self):
with tempfile.TemporaryDirectory() as tmp_dirname:
tmp_path = os.path.join(tmp_dirname, 'tmp_filename')
expected_file_contents = 'Deleted FakeSlowModel'
with TestPipeline() as pipeline:
# Start with bad example which gets timed out.
# Then provide plenty of time for GC to happen.
examples = [20] + [1] * 15 + [20, 20, 20]
examples = [20] + [1] * 15
expected_good = [1] * 15
expected_bad = [20, 20, 20, 20]
expected_bad = [20]
pcoll = pipeline | 'start' >> beam.Create(examples)
main, other = pcoll | base.RunInference(
FakeSlowModelHandler(
Expand All @@ -909,7 +910,7 @@ def test_run_inference_timeout_does_garbage_collection(self):

with open(tmp_path) as f:
s = f.read()
self.assertNotEqual(s, '')
self.assertEqual(s, expected_file_contents)

def test_run_inference_impl_inference_args(self):
with TestPipeline() as pipeline:
Expand Down
Loading