-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prism] Remove unused code #32414
[Prism] Remove unused code #32414
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This PR removed tests but the test result report shows test number remains the same as the main branch Later I realize Line 235 in e8c6a8c
so the tests never exercised. I would suggest add |
Reminder, please take a look at this pr: @Abacn |
Tried to add
In general, PrismLocatorTest relies on real URLs (https://github.com/apache/beam/releases/tag/v2.57.0/apache_beam-v2.57.0-prism-darwin-amd64.zip, https://example.com/i/dont/exist.zip) which are not a good unit test. Can we use mock there? |
funny that "fix xxxx" phrase also leads to close a PR, not only an Issue |
This PR addresses #31793 removing unused code later discovered not needed.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.