Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo part of artifact action upgrade to fix workflow #32401

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Sep 5, 2024

https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes breaks our wheels flow since we rely on uploading multiple times to the same artifact. This fixes the problem temporarily until we get a more full upgrade.

Before: https://github.com/apache/beam/actions/runs/10723236423
With my change: https://github.com/apache/beam/actions/runs/10724426641


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 5, 2024
@damccorm damccorm marked this pull request as ready for review September 5, 2024 17:56
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit 6901d7c into master Sep 5, 2024
33 checks passed
@damccorm damccorm deleted the users/damccorm/wheels_fix branch October 28, 2024 17:05
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants