-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prism] Skip python tests that require an expansion service at this time. #32182
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
R: @jrmccluskey I'm pretty confident the tests I'm skipping are not what's causing the checks to fail, though I am re-running them. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
The line failing is here: beam/sdks/java/container/common.gradle Line 118 in 7af43ee
I'm inclined to say that is not an associated issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only nit is that it may be better to comment out the test content to restore later unless you intend to write new tests later
Oh i originally copied those from the Flink runner tests, so nothing of value has been lost. Thanks! |
…ime. (apache#32182) * [prism] Skip tests that require an expansion service at this time. * Remove extra python imports. --------- Co-authored-by: lostluck <[email protected]>
Related to #28187.
Skip the copied kafka, SQL, and external transform tests that require an expansion Service stood up.
We should eventually have a post commit for these, but in the short term, filter them out to enable a pre-commit suite to execute.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.