Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prism] Skip python tests that require an expansion service at this time. #32182

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

lostluck
Copy link
Contributor

Related to #28187.

Skip the copied kafka, SQL, and external transform tests that require an expansion Service stood up.

We should eventually have a post commit for these, but in the short term, filter them out to enable a pre-commit suite to execute.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck lostluck changed the title [prism] Skip tests that require an expansion service at this time. [prism] Skip python tests that require an expansion service at this time. Aug 14, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@lostluck
Copy link
Contributor Author

R: @jrmccluskey

I'm pretty confident the tests I'm skipping are not what's causing the checks to fail, though I am re-running them.

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@jrmccluskey
Copy link
Contributor

The line failing is here:

throw new GradleException("java${imageJavaVersion}Home or compatible properties required for imageJavaVersion=${imageJavaVersion}. Re-run with -Pjava${imageJavaVersion}Home")

I'm inclined to say that is not an associated issue

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nit is that it may be better to comment out the test content to restore later unless you intend to write new tests later

@lostluck
Copy link
Contributor Author

LGTM, only nit is that it may be better to comment out the test content to restore later unless you intend to write new tests later

Oh i originally copied those from the Flink runner tests, so nothing of value has been lost.

Thanks!

@lostluck lostluck merged commit f1f5f77 into apache:master Aug 14, 2024
87 of 89 checks passed
@lostluck lostluck deleted the filterExpansionTests branch August 14, 2024 22:39
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
…ime. (apache#32182)

* [prism] Skip tests that require an expansion service at this time.

* Remove extra python imports.

---------

Co-authored-by: lostluck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants