Limit the size of bundles of elements emitted by SDK into the data output stream. #31581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvalentyn
commented
Jun 12, 2024
robertwb
reviewed
Jun 12, 2024
| @@ -639,8 +639,13 @@ def _write_outputs(self): | |||
| streams = [self._to_send.get()] | |||
| try: | |||
| # Coalesce up to 100 other items. | |||
| total_size_bytes = 0 | |||
There was a problem hiding this comment.
Or streams[0].ByteSize()?
robertwb
approved these changes
Jun 12, 2024
tvalentyn
force-pushed
the
large_elements
branch
from
c1ad637 to
2931941
Compare
|
Run Python 3.8 PostCommit |
|
Filed #31596 for a test flake. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.