Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb Redistribute "allow duplicates" property to Dataflow #31490

Merged
merged 38 commits into from
Jun 17, 2024

Conversation

celeste-zeng
Copy link
Contributor

@celeste-zeng celeste-zeng commented Jun 4, 2024

The DataflowGroupByKey is identical to the Beam GroupByKey transform except for having a allowDuplicates property plumbed from the Redistribute transform.

Added corresponding override for RedistributeByKey, a translator for DataflowGroupByKey, and override builder in the runner.

Tested internally by running a load test and passed all Github actions tests.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jun 4, 2024
@celeste-zeng
Copy link
Contributor Author

R:@kennknowles

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added model and removed model labels Jun 11, 2024
@github-actions github-actions bot added model and removed model labels Jun 11, 2024
@github-actions github-actions bot added model and removed model labels Jun 11, 2024
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Let's add the other test suites, and also do internal testing.

@github-actions github-actions bot added model and removed model labels Jun 12, 2024
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! This became a very clear and minimal result that gets the job done well. (yes, there is a lot of boilerplate, but that is Java and Beam for you)

@kennknowles kennknowles changed the title Add a customized DataflowGroupByKey primitive transform to plumb Redistribute transform's property Plumb Redistribute "allow duplicates" property to Dataflow Jun 17, 2024
@kennknowles kennknowles merged commit 3a53181 into apache:master Jun 17, 2024
21 checks passed
celeste-zeng added a commit to celeste-zeng/beam that referenced this pull request Jun 17, 2024
)

 - Since Dataflow only translates primitives, added a runner-specific DataflowGroupByKey primitive
 - Added override for RedistributeByKey that replaces GBK with Dataflow GBK, to plumb property
kennknowles added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants