-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumb Redistribute "allow duplicates" property to Dataflow #31490
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
.../core/src/main/java/org/apache/beam/sdk/util/construction/DataflowGroupByKeyTranslation.java
Outdated
Show resolved
Hide resolved
...ow-java/src/main/java/org/apache/beam/runners/dataflow/RedistributeByKeyOverrideFactory.java
Outdated
Show resolved
Hide resolved
0ddd900
to
1da17e6
Compare
...ow-java/src/main/java/org/apache/beam/runners/dataflow/RedistributeByKeyOverrideFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Let's add the other test suites, and also do internal testing.
.../core/src/main/java/org/apache/beam/sdk/util/construction/DataflowGroupByKeyTranslation.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! This became a very clear and minimal result that gets the job done well. (yes, there is a lot of boilerplate, but that is Java and Beam for you)
The DataflowGroupByKey is identical to the Beam GroupByKey transform except for having a allowDuplicates property plumbed from the Redistribute transform.
Added corresponding override for RedistributeByKey, a translator for DataflowGroupByKey, and override builder in the runner.
Tested internally by running a load test and passed all Github actions tests.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.