Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iceberg load test #31392

Closed
wants to merge 15 commits into from
Closed

Add iceberg load test #31392

wants to merge 15 commits into from

Conversation

ahmedabu98
Copy link
Contributor

@ahmedabu98 ahmedabu98 commented May 24, 2024

Adding a load test for IcebergIO

Separating integration test (from #31220) into its own suite

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.55%. Comparing base (e2d6246) to head (1c5b4f0).
Report is 5 commits behind head on master.

Current head 1c5b4f0 differs from pull request most recent head 50b2488

Please upload reports for the commit 50b2488 to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #31392       +/-   ##
=============================================
- Coverage     71.40%   68.55%    -2.86%     
- Complexity     1474    14921    +13447     
=============================================
  Files           900     2636     +1736     
  Lines        114166   222073   +107907     
  Branches       1076    11825    +10749     
=============================================
+ Hits          81519   152234    +70715     
- Misses        30619    63644    +33025     
- Partials       2028     6195     +4167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmedabu98
Copy link
Contributor Author

Performance test ran successfully with the following jobs:

Write (2024-05-28_14_38_09-6308924367920992234):
image

  • Wrote 1 billion records
  • Autoscaled to 125 workers
  • Total elapsed time: 18.5 min

Read (2024-05-28_14_56_50-10726183500998931365):
image

  • Read 1 billion records
  • Autoscaled to 42 workers
  • Total elapsed time: 21 min

@ahmedabu98
Copy link
Contributor Author

R: @kennknowles

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@github-actions github-actions bot removed the python label Jun 18, 2024
@ahmedabu98
Copy link
Contributor Author

ahmedabu98 commented Jun 18, 2024

Looks like populating the data did have an effect. Pipelines used a lot more workers but finished in roughly the same amount of time.

Write (2024-06-17_18_21_14-2727804973398206918)

image
  • Wrote 1 billion records (2 TB)
  • Autoscaled to 373 workers
  • Total elapsed time: ~59 min (Actual write finished in 14 min. Took a long time to clean up and stop worker pool)

Read (2024-06-17_19_20_46-7349681781857878664)

image
  • Read 1 billion records (2 TB)
  • Autoscaled to 204 workers
  • Total elapsed time: 13 min

@ahmedabu98 ahmedabu98 requested a review from kennknowles June 20, 2024 23:15
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 20, 2024
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants