-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Beam from wheels in Dependency Compat Test Suite. #31308
Conversation
Currently testing this on https://github.com/apache/beam/actions/runs/9101961896 |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
if I remember correctly, useWheelDistribution is only effective for Dataflow test (it changes sdk_location pipeline option to wheel). However these tests are running on direct runner. This change alone is a no-op yet? |
I thought so too, but after you dug up the PR for me (thanks!) that added this option, i looked closer in https://github.com/apache/beam/blob/6cb30cc5c86ce394ca558c431af55a935b8d9d6b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L3078C121-L3078C136 |
reminder that due to nature of GHA permissions, the signal on the PR #31305 itself is not accurate, even though it includes a commit from this PR, GHA still runs long because it hasn't taken effect yet. |
Oh, I see, yeah, the functionality is added in #28385 making useWheelDistribution working for tox |
Dependency postcommit suite runs multiple small suites of unit tests. Installing beam takes 3-4 minutes to build a wheel. Using a wheel to install beam should speed up the suite, since the wheel will be built once.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.