Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] - Normalize YAML PubSub format #31068

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

ffernandez92
Copy link
Contributor

addresses #31067


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@brucearctor brucearctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. will leave open a couple days for anyone to comment, though should be fine to merge

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any examples we need to update?

@brucearctor
Copy link
Contributor

@ffernandez92 -- once you've confirmed docs/website/etc updated [ if necessary ], we can merge.

@robertwb -- should we also update syntax/style guide? That seems outside scope of this PR, but perhaps worth specifying to further specify desired conventions.

@github-actions github-actions bot added website and removed website labels Apr 23, 2024
@ffernandez92
Copy link
Contributor Author

@brucearctor, I've updated the docs, website, and tests [I didn't see specific examples to fix] to ensure they are consistent with the new uppercase scenario. They currently function regardless of whether it's upper or lower case. However, I'd like to be prepared for when we deprecate the lowercase option so that we don't need to modify the tests.
As you've said, we can leave the PR open for a couple of days in case there is more feedback

@brucearctor brucearctor merged commit de665b7 into apache:master Apr 23, 2024
76 checks passed
@ffernandez92 ffernandez92 deleted the pubsub-yaml-upper branch April 24, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants