-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Allow lambda function in bigtable handler to build a custom row key #30974
Conversation
bd28cf7
to
4b351c2
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks - just had a minor nit. Looks like lint is red too (rest are flakes I think)
sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - added one suggestion, feel free to merge once accepted or comment if you disagree
sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py
Outdated
Show resolved
Hide resolved
…e.py Co-authored-by: Danny McCormick <[email protected]>
Unrelated failure in PyCoverage - Merging this. Thanks for the review! |
Allow users to use a custom function to build a composite row key from for the Bigtable row.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.