Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Pin keras version for tensorflow inference test #30614

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Mar 12, 2024

Fixes #30613

Pin keras version for tf_inference_it_test in postcommits to less than 3.0.0. Created #30616 to support Keras 3.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@riteshghorse riteshghorse changed the title pin keras version [Python] Pin keras version for tensorflow inference test Mar 12, 2024
@riteshghorse
Copy link
Contributor Author

Tests are now passing
image

@riteshghorse riteshghorse marked this pull request as ready for review March 12, 2024 20:24
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

We should unpin the version after #30616 is fixed , precisely to detect issues like this. Can you add a TODO?

@tvalentyn
Copy link
Contributor

tvalentyn commented Mar 12, 2024

LGTM otherwise

@riteshghorse
Copy link
Contributor Author

Yes, added that as part of the task itself. Thanks!

@riteshghorse riteshghorse merged commit 289bbc4 into apache:master Mar 13, 2024
75 checks passed
@riteshghorse riteshghorse deleted the fix-pc branch March 13, 2024 02:10
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Python PostCommit is continuously failing for tf_inference_it_test
2 participants