Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag for direct path that reads from system properties #30588

Merged
merged 5 commits into from
Mar 14, 2024
Merged

add flag for direct path that reads from system properties #30588

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
741ff98
add flag for direct path that reads from system properties
m-trieu Mar 8, 2024
4bc8d4a
remove unused imports
m-trieu Mar 8, 2024
2ceefda
change flag name to something more unique
m-trieu Mar 8, 2024
2ae8e64
remove instance factory and just use boolean
m-trieu Mar 11, 2024
5b43254
fix option name format
m-trieu Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../main/java/org/apache/beam/runners/dataflow/options/DataflowStreamingPipelineOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,14 @@ public interface DataflowStreamingPipelineOptions extends PipelineOptions {

void setWindmillServiceStreamMaxBackoffMillis(int value);

@Description(
"If true, Dataflow streaming pipeline will be running in direct path mode."
+ " VMs must have IPv6 enabled for this to work.")
@Default.Boolean(false)
boolean getIsWindmillServiceDirectPathEnabled();

void setIsWindmillServiceDirectPathEnabled(boolean isWindmillServiceDirectPathEnabled);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the is, otherwise specifying the flag looks odd IMO
--isWindmillServiceDirectPathEnabled=true


/**
* Factory for creating local Windmill address. Reads from system propery 'windmill.hostport' for
* backwards compatibility.
Expand Down
Loading