Put an explanatory comment in trigger files that exist #30586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damccorm
approved these changes
Mar 8, 2024
Abacn
reviewed
Mar 8, 2024
|
PostCommit Java ValidatesRunner SparkStructuredStreaming failing is fixed in #30589 -- may need another cherry-pick into release branch to get this test green also |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
kennknowles
force-pushed
the
trigger_file_comments
branch
from
fc8728c to
43b69c3
Compare
kennknowles
force-pushed
the
trigger_file_comments
branch
from
43b69c3 to
97f8dae
Compare
|
I'm being pedantic about actually waiting for green here, but TBH it is a waste of time and resources. Perhaps we just go for it and merge? |
SGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed these files that got merged with PRs. We ought to be more conscientious! But they could serve a purpose. Rather than deleting them, we can add a little comment that says how to use them. Yes it is redundant to put it in every file but probably nice for each one to just say what it is for rather than cause you to look around.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.