Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JsonIgore for usePublicIps #30484

Merged

Conversation

damondouglas
Copy link
Contributor

This PR fixes #30483. Removing the JsonIgnore annotation restores visibility of the parameter on the console.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas marked this pull request as ready for review March 4, 2024 18:05
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damondouglas
Copy link
Contributor Author

R: @Abacn

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@kennknowles
Copy link
Member

Just a note to be careful, because it isn't just a visibility issue. It will also cause this pipeline option to govern execution on the worker. Some pipeline options do cause issues unless they are cleared before the worker gets this. This one is probably fine.

@kennknowles
Copy link
Member

Incidentally we probably need to add most of our team to the dataflow and runner tag combination to get reviewers.

@kennknowles kennknowles merged commit 89366bb into apache:master Mar 5, 2024
16 checks passed
@damondouglas damondouglas deleted the remove-jsonignore-usepublicips branch September 25, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: usePublicIps does not appear on Dataflow UI console
2 participants