-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Drain to Job Management proto #30157
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30157 +/- ##
=======================================
Coverage 38.42% 38.42%
=======================================
Files 697 697
Lines 102215 102215
=======================================
Hits 39272 39272
Misses 61315 61315
Partials 1628 1628
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assigning reviewers. If you would like to opt out of this review, comment R: @lostluck for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
c1b8b3b
to
9ad3079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// Drain is a request to: | ||
// - stop a pipeline Job from ingesting new data from input sources | ||
// - process remaining data in the pipeline | ||
// - truncate Splittable DoFns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"truncate Unbounded Restrictions"
This PR closes #30155 and addresses #29669 and #30250 by:
adding a Drain method to the Job Management proto
regenerate stubs for the Go SDK via:
go generate
in sdks/go/pkg/beam/modelTo validate this change, I performed the following validations for each of the three SDKS:
Java validation
Using IntelliJ ran gradle tasks:
Python validation
Using pyenv
Go validation
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.