More efficient map side inputs for small maps. #29587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ability to perform point lookups for multi-map side inputs is great for maps that are too large to fit into memory, but can be very inefficient in requiring an entire state request per key for small maps. This change adds an optional protocol to request an entire map as a stream of key-values in one (possibly paginated) API call, and uses this to bulk pre-fetch an initial set of values from the map before falling back to point lookups.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
robertwb
force-pushed
the
small-map-side-input
branch
from
ed05de9 to
c299bd1
Compare
priyansndesai
approved these changes
Dec 7, 2023
|
Yes, we'll probably want to do that there too. The most important is for Java, but I have Python too because that's where I prototyped it (including the runner side). |
|
This is for #29691 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to perform point lookups for multi-map side inputs is great for maps that are too large to fit into memory, but can be very inefficient in requiring an entire state request per key for small maps.
This change adds an optional protocol to request an entire map as a stream of key-values in one (possibly paginated) API call, and uses this to bulk pre-fetch an initial set of values from the map before falling back to point lookups.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.