Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Start Go RequestResponseIO implementation #29488

Closed
wants to merge 3 commits into from

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Nov 19, 2023

This PR addresses #28934, addresses #28711, and addresses #28710 using the Go SDK:


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas
Copy link
Contributor Author

damondouglas commented Nov 19, 2023

@riteshghorse and @lostluck FYI

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 126 lines in your changes are missing coverage. Please review.

Comparison is base (23b1fe9) 37.85% compared to head (6fc9768) 37.80%.
Report is 4 commits behind head on master.

Files Patch % Lines
sdks/go/pkg/beam/io/rrio/rrio.go 3.07% 126 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29488      +/-   ##
==========================================
- Coverage   37.85%   37.80%   -0.06%     
==========================================
  Files         690      691       +1     
  Lines      101307   101476     +169     
==========================================
+ Hits        38353    38360       +7     
- Misses      61362    61520     +158     
- Partials     1592     1596       +4     
Flag Coverage Δ
go 53.20% <3.07%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the build label Nov 21, 2023
@damondouglas
Copy link
Contributor Author

Closing this and will re-submit later when there is time.

@damondouglas damondouglas deleted the beam-rrio-caller-go branch February 8, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant