Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete directories and objects instead of only objects for a given path #29477

Closed
wants to merge 1 commit into from

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Nov 17, 2023

Fixes: #27605


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (bb310e0) 37.85% compared to head (d4167e9) 37.85%.
Report is 353 commits behind head on master.

Files Patch % Lines
sdks/python/apache_beam/io/gcp/gcsio.py 11.11% 8 Missing ⚠️
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29477      +/-   ##
==========================================
- Coverage   37.85%   37.85%   -0.01%     
==========================================
  Files         690      690              
  Lines      101305   101315      +10     
==========================================
+ Hits        38350    38351       +1     
- Misses      61362    61371       +9     
  Partials     1593     1593              
Flag Coverage Δ
python 29.00% <9.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jan 17, 2024
@AnandInguva AnandInguva closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Python GCSFileSystem.delete does not recursively delete
1 participant