Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [RRIO] [Call] Caller, SetupTeardown Interfaces and Integration Tests #29303

Closed
wants to merge 14 commits into from

Conversation

damondouglas
Copy link
Contributor

This WIP PR begins the Python RRIO implementation.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the infra label Nov 8, 2023
@@ -0,0 +1,100 @@
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rrio.py instead of the full name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for reviewing, @liferoad. I personally prefer with you the abbreviation. It was on the original Java until the Java was changed to the full requestresponse (without the io part of the name). To maintain consistency with the Java, I reasoned to spell out the full name. What do others prefer (cc: @Abacn , @johnjcasey , @riteshghorse , @ahmedabu98)

sdks/python/setup.py Outdated Show resolved Hide resolved
@damondouglas
Copy link
Contributor Author

@riteshghorse I wonder if the numerous failed checks is due to needing to either skip the integration test or configure so it passes during the checks. I prefer skipping the integration test for now in this PR.

@riteshghorse
Copy link
Contributor

Could be. RAT failure is because of missing license in files. Let me check the others

@damondouglas
Copy link
Contributor Author

I'm attempting one by one and looking at the checks they are performing and running them locally in hopes of finding the issue.

@github-actions github-actions bot added the build label Nov 8, 2023
@riteshghorse
Copy link
Contributor

I'm also seeing this error

ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/.test-infra/mock-apis/src/main/python' 

in beam_PreCommit_Python_Coverage

@riteshghorse
Copy link
Contributor

I'm also seeing this error

ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/.test-infra/mock-apis/src/main/python' 

in beam_PreCommit_Python_Coverage

It looks like it didn't include the two .. while building the path for mock-apis - 'mock-apis@ file:///.test-infra/mock-apis/src/main/python'

@riteshghorse
Copy link
Contributor

Weird why parquetIO tests are failing here.. checking it now

@github-actions github-actions bot removed the infra label Nov 10, 2023
@damondouglas
Copy link
Contributor Author

@riteshghorse as we talked about, closing this PR.

@damondouglas damondouglas deleted the rrio-call-iface-py branch February 8, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants