-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [RRIO] [Call] Caller, SetupTeardown Interfaces and Integration Tests #29303
Conversation
@@ -0,0 +1,100 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rrio.py instead of the full name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for reviewing, @liferoad. I personally prefer with you the abbreviation. It was on the original Java until the Java was changed to the full requestresponse
(without the io part of the name). To maintain consistency with the Java, I reasoned to spell out the full name. What do others prefer (cc: @Abacn , @johnjcasey , @riteshghorse , @ahmedabu98)
72d4271
to
ec66b0e
Compare
@riteshghorse I wonder if the numerous failed checks is due to needing to either skip the integration test or configure so it passes during the checks. I prefer skipping the integration test for now in this PR. |
Could be. RAT failure is because of missing license in files. Let me check the others |
I'm attempting one by one and looking at the checks they are performing and running them locally in hopes of finding the issue. |
I'm also seeing this error
|
It looks like it didn't include the two |
Weird why parquetIO tests are failing here.. checking it now |
@riteshghorse as we talked about, closing this PR. |
This WIP PR begins the Python RRIO implementation.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.