-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix XVR test fail python docker #29256
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29256 +/- ##
==========================================
- Coverage 38.28% 38.28% -0.01%
==========================================
Files 689 689
Lines 101972 101986 +14
==========================================
+ Hits 39045 39046 +1
- Misses 61351 61361 +10
- Partials 1576 1579 +3
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run XVR_Flink PostCommit Tested 9 times and Task :sdks:python:container:py38:copyLauncherDependencies (beam_PostCommit_XVR_Flink_PR run 325-333) no longer show "NO-SOURCE" status. From gradle/gradle#24368 it is suspected that the issue is triggered when
and probably need some other prerequisites, then the first copy task in this project intermittently skipped with NO-SOURCE. This workaround make another copy job that source guaranteed to exist (it copies licenses stored in beam repo) supercedes copyLauncherDependencies task --- and it seems working |
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Hopefully fixes #29220
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.