Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XVR test fail python docker #29256

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fix XVR test fail python docker #29256

merged 1 commit into from
Nov 2, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Nov 1, 2023

Hopefully fixes #29220

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #29256 (5f45dc3) into master (1f5bddc) will decrease coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #29256      +/-   ##
==========================================
- Coverage   38.28%   38.28%   -0.01%     
==========================================
  Files         689      689              
  Lines      101972   101986      +14     
==========================================
+ Hits        39045    39046       +1     
- Misses      61351    61361      +10     
- Partials     1576     1579       +3     
Flag Coverage Δ
go 53.42% <ø> (+<0.01%) ⬆️
python 29.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor Author

Abacn commented Nov 1, 2023

Run XVR_Flink PostCommit

Tested 9 times and Task :sdks:python:container:py38:copyLauncherDependencies (beam_PostCommit_XVR_Flink_PR run 325-333) no longer show "NO-SOURCE" status. From gradle/gradle#24368 it is suspected that the issue is triggered when

  • the source for the copy task does not exist at configuration time
  • different tasks share the same source folder

and probably need some other prerequisites, then the first copy task in this project intermittently skipped with NO-SOURCE. This workaround make another copy job that source guaranteed to exist (it copies licenses stored in beam repo) supercedes copyLauncherDependencies task --- and it seems working

@Abacn Abacn marked this pull request as ready for review November 1, 2023 19:20
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @m-trieu for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Nov 2, 2023

R: @AnandInguva @tvalentyn

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn Abacn merged commit bc29b96 into apache:master Nov 2, 2023
90 checks passed
@Abacn Abacn deleted the fixxvrpydocker branch November 2, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants