-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to run performance regression checks on Beam IO Load tests. #29226
Add ability to run performance regression checks on Beam IO Load tests. #29226
Conversation
R: @AnandInguva, @Abacn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
sdks/python/apache_beam/testing/analyzers/load_test_perf_analysis.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, just had a few minor points
sdks/python/apache_beam/testing/analyzers/load_test_perf_analysis.py
Outdated
Show resolved
Hide resolved
bbdbeba
to
b10369e
Compare
Codecov Report
@@ Coverage Diff @@
## master #29226 +/- ##
==========================================
- Coverage 38.33% 38.30% -0.04%
==========================================
Files 688 689 +1
Lines 101840 101938 +98
==========================================
+ Hits 39041 39043 +2
- Misses 61219 61315 +96
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
a140c2c
to
643a1e8
Compare
643a1e8
to
6fff1f7
Compare
Merging because of the previous approvals |
Not a big deal, but in general we should wait for all checks to pass before merging |
This PR adds ability to run regression checks against Beam IO load tests.
Below is the command to run this,
We can automate runs for these regression checks by adding a GH workflow in a separate PR.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.