Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to run performance regression checks on Beam IO Load tests. #29226

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

pranavbhandari24
Copy link
Contributor

@pranavbhandari24 pranavbhandari24 commented Oct 31, 2023

This PR adds ability to run regression checks against Beam IO load tests.

Below is the command to run this,

python3 apache_beam/testing/analyzers/load_test_perf_analysis.py --config_file_path=apache_beam/testing/analyzers/io_tests_config.yaml

We can automate runs for these regression checks by adding a GH workflow in a separate PR.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@pranavbhandari24
Copy link
Contributor Author

R: @AnandInguva, @Abacn

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just had a few minor points

@pranavbhandari24 pranavbhandari24 force-pushed the add-regression_check-io branch 2 times, most recently from bbdbeba to b10369e Compare October 31, 2023 20:45
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #29226 (6fff1f7) into master (9364d7d) will decrease coverage by 0.04%.
Report is 12 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #29226      +/-   ##
==========================================
- Coverage   38.33%   38.30%   -0.04%     
==========================================
  Files         688      689       +1     
  Lines      101840   101938      +98     
==========================================
+ Hits        39041    39043       +2     
- Misses      61219    61315      +96     
  Partials     1580     1580              
Flag Coverage Δ
python 29.90% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/yaml/yaml_transform.py 0.00% <0.00%> (ø)
...ache_beam/testing/analyzers/perf_analysis_utils.py 0.00% <0.00%> (ø)
..._beam/testing/analyzers/load_test_perf_analysis.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pranavbhandari24 pranavbhandari24 force-pushed the add-regression_check-io branch 3 times, most recently from a140c2c to 643a1e8 Compare November 1, 2023 14:49
@damccorm damccorm added this to the 2.52.0 Release milestone Nov 1, 2023
@ahmedabu98
Copy link
Contributor

Merging because of the previous approvals

@ahmedabu98 ahmedabu98 merged commit ea8596f into apache:master Nov 1, 2023
71 of 72 checks passed
@damccorm
Copy link
Contributor

damccorm commented Nov 1, 2023

Not a big deal, but in general we should wait for all checks to pass before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants