-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Add device param to HuggingFacePipelineModelHandler #29223
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29223 +/- ##
==========================================
- Coverage 38.32% 38.27% -0.05%
==========================================
Files 688 689 +1
Lines 101846 101986 +140
==========================================
+ Hits 39032 39039 +7
- Misses 61233 61366 +133
Partials 1581 1581
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Btw pytorch model handlers use CPU as default. It would be good to make that default GPU as well since we are moving in that direction. |
Tests are done.. failing test seems to be a timeout issue not related to this PR |
I agree - retrying to get to green, otherwise LGTM |
Fixes #29218
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.