Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sickbay test_bigtable_write on Dataflow runner #29197

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Oct 30, 2023

This is currently very flaky (bordering on permared) and represents a known issue with the bigtable client. This will hopefully make our python postcommit a bit less flaky (though it likely won't eliminate flakiness entirely)

Run with this sickbayed - https://github.com/apache/beam/actions/runs/6806746813

Part of #29076


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #29197 (398f686) into master (38f3b21) will increase coverage by 0.03%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

❗ Current head 398f686 differs from pull request most recent head aa2e8ba. Consider uploading reports for the commit aa2e8ba to get more accurate results

@@            Coverage Diff             @@
##           master   #29197      +/-   ##
==========================================
+ Coverage   38.34%   38.38%   +0.03%     
==========================================
  Files         693      687       -6     
  Lines      102199   101745     -454     
==========================================
- Hits        39188    39051     -137     
+ Misses      61423    61113     -310     
+ Partials     1588     1581       -7     
Flag Coverage Δ
python 29.98% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@damccorm
Copy link
Contributor Author

Run Python 3.8 PostCommit

@damccorm
Copy link
Contributor Author

Currently python postcommit is pretty broken on Actions, so this doesn't fully fix things, but it should help.

@damccorm damccorm marked this pull request as ready for review November 9, 2023 21:24
@damccorm
Copy link
Contributor Author

damccorm commented Nov 9, 2023

assign set of reviewers

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit f47d473 into master Nov 9, 2023
71 of 75 checks passed
@damccorm damccorm deleted the users/damccorm/sb branch November 9, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants