-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RRIO] [Call] Implement PTransform without adaptive throttling #29144
[RRIO] [Call] Implement PTransform without adaptive throttling #29144
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ApiIOError.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java
Show resolved
Hide resolved
Thank you @chamikaramj for your help and insight with this. It still shows you are requesting changes and wanted to make sure all was well before Squash/Merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please self merge when tests pass.
This PR addresses #28711 by implementing the Call PTransform that executes user custom code.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.