Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in HistogramData.java and HistogramDataTest.java #29105

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix typos in HistogramData.java and HistogramDataTest.java #29105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/java/core/src/main/java/org/apache/beam/sdk/util/HistogramData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public static HistogramData linear(double start, double width, int numBuckets) {
}

/**
* Returns a histogram object wiht exponential boundaries. The input parameter {@code scale}
* Returns a histogram object with exponential boundaries. The input parameter {@code scale}
* determines a coefficient 'base' which species bucket boundaries.
*
* <pre>
Expand Down Expand Up @@ -381,7 +381,7 @@ private int getBucketIndexNegativeScale(int value) {
return getBucketIndexZeroScale(value) >> (-getScale());
}

// This method is valid for all 'scale' values but we fallback to more effecient methods for
// This method is valid for all 'scale' values but we fallback to more efficient methods for
// non-positive scales.
// For a value>base we would like to find an i s.t. :
// base^i <= value < base^(i+1)
Expand Down
2 changes: 1 addition & 1 deletion sdks/java/core/src/test/java/org/apache/beam/sdk/util/HistogramDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ public void testIncrementBucketCountByIndex() {

// The following tests cover exponential buckets.
@Test
public void testExponentialBuckets_PostiveScaleRecord() {
public void testExponentialBuckets_PositiveScaleRecord() {
// Buckets will be:
// Index Range
// Underflow (-inf, 0)
Expand Down
Loading